Skip to content

chore: removes premium integration tags for released ones#39472

Merged
sneha122 merged 1 commit intoreleasefrom
chore/remove-premimum-integration-tag
Feb 27, 2025
Merged

chore: removes premium integration tags for released ones#39472
sneha122 merged 1 commit intoreleasefrom
chore/remove-premimum-integration-tag

Conversation

@sneha122
Copy link
Contributor

@sneha122 sneha122 commented Feb 27, 2025 •
edited by github-actions bot
Loading

Description

This PR removes premimum/soon tags from paragon integrations as soon as they become available generally

Fixes #39439
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13561777558
Commit: 6e50537
Cypress dashboard.
Tags: @tag.Datasource
Spec:

Thu, 27 Feb 2025 09:04:46 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Enhanced the premium integrations display with improved filtering that now considers active plugin selections for more refined results.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2025 •
edited
Loading

Walkthrough

The changes update the filtering logic for premium integrations in the integration editor. A new array variable, pluginNames, is introduced in two UI components to extract plugin names and is passed to the getFilteredPremiumIntegrations function. The function’s signature in the constants file is updated to accept this new parameter, and its filtering logic is modified to use pluginNames instead of hardcoded values.

Changes

File(s) Change Summary
.../Editor/APIOrSaasPlugins.tsx
.../Editor/EmptySearchedPlugins.tsx		 Added a pluginNames variable to extract plugin names and updated calls to getFilteredPremiumIntegrations by passing pluginNames along with isExternalSaasEnabled.
.../Editor/PremiumDatasources/Constants.ts Updated getFilteredPremiumIntegrations signature to include pluginNames: string[] and modified the filtering logic to exclude integrations based on the provided plugin names.

Sequence Diagram(s)

sequenceDiagram
    participant UI as Editor Component
    participant Filter as getFilteredPremiumIntegrations
    participant Data as Premium Integration Data
    UI->>Filter: Call getFilteredPremiumIntegrations(isExternalSaasEnabled, pluginNames)
    Filter->>Data: Filter out integrations using pluginNames
    Data-->>Filter: Return filtered integrations
    Filter-->>UI: Return premium integrations
Loading

Possibly related PRs

Suggested labels

Widgets Product, Task, skip-changelog, ok-to-test, Integrations Product, Integrations Pod General, Query & Widgets Pod

Suggested reviewers

  • ApekshaBhosale
  • AmanAgarwal041

Poem

In our code's bright domain, a spark ignites,
Plugin names guide our filter to new heights.
A tweak so small, yet clearly in sight,
Precision in logic, shining with light.
Celebrate these changes, crisp and just right!
🚀 Happy coding in innovation’s flight!

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fdf63a9 and 6e50537.

📒 Files selected for processing (3)
  • app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx (1 hunks)
  • app/client/src/pages/Editor/IntegrationEditor/EmptySearchedPlugins.tsx (1 hunks)
  • app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Constants.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-build / client-build
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-prettier / prettier-check
🔇 Additional comments (6)
app/client/src/pages/Editor/IntegrationEditor/EmptySearchedPlugins.tsx (2)

47-48: Good addition of dynamic plugin name extraction.

Extracting plugin names into a separate array is a clean approach that makes the code more maintainable and readable.

56-56: Properly updated function call with new parameter.

The function call has been correctly updated to pass the plugin names to getFilteredPremiumIntegrations, which aligns with the updated function signature.

app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx (2)

331-332: Clean implementation of plugin names extraction.

Extracting plugin names from allPlugins into a separate array is a good practice that improves readability and maintainability.

336-337: Function call correctly updated with new parameter.

The implementation properly passes the plugin names to getFilteredPremiumIntegrations, ensuring consistent behavior across the application.

app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Constants.ts (2)

28-31: Function signature update is appropriate.

The function signature has been properly updated to accept the new pluginNames parameter, maintaining backward compatibility while adding new functionality.

33-35: Good refactoring from hardcoded values to dynamic filtering.

The filtering logic has been improved to use the provided pluginNames array instead of hardcoded values, making the code more maintainable and adaptable to changes in available plugins.

This change successfully implements the PR objective of removing premium integration tags for released integrations by ensuring that integrations that are already available as regular plugins don't also appear in the premium integrations list.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sneha122 sneha122 added the ok-to-test Required label for CI label Feb 27, 2025
@github-actions github-actions bot added Task A simple Todo skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Feb 27, 2025
@sneha122
Copy link
Contributor Author

sneha122 commented Feb 27, 2025

/build-deploy-preview skip-tests=true

@AmanAgarwal041 AmanAgarwal041 changed the title chore: removes premium integrationt tags for released ones chore: removes premium integration tags for released ones Feb 27, 2025
@github-actions
Copy link

github-actions bot commented Feb 27, 2025

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13561789967.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 39472.
recreate: .

@github-actions
Copy link

github-actions bot commented Feb 27, 2025

Deploy-Preview-URL: https://ce-39472.dp.appsmith.com

@sneha122 sneha122 merged commit 024eb1b into release Feb 27, 2025
49 checks passed
@sneha122 sneha122 deleted the chore/remove-premimum-integration-tag branch February 27, 2025 09:14
@coderabbitai coderabbitai bot mentioned this pull request Feb 28, 2025
Merged
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Mar 31, 2025
Merged
2 tasks
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Apr 12, 2025
@sneha122
chore: removes premium integration tags for released ones (appsmithor…
3306049 
…g#39472)

## Description
This PR removes premimum/soon tags from paragon integrations as soon as
they become available generally


Fixes appsmithorg#39439 
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13561777558>
> Commit: 6e50537
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13561777558&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Thu, 27 Feb 2025 09:04:46 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced the premium integrations display with improved filtering that
now considers active plugin selections for more refined results.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AmanAgarwal041 AmanAgarwal041 AmanAgarwal041 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task]: Remove slack from premium integration list once it is made available for all

2 participants

@sneha122 @AmanAgarwal041